Creating an NRaas project Cupcake Question

Talk nerdy to us here.
Post Reply
icarus_allsorts
Reactions:
Posts: 213
Joined: March 8th, 2012, 6:00 pm

Cupcake Question

Post by icarus_allsorts » January 8th, 2016, 11:38 am

Was looking in the code for Cupcake and considering tweaking the PurchaseItemEx interaction to maybe push sims who bought food autonomously to actually eat the food. I'm just wondering though, regarding the Definition class, was there a particular reason for hiding all the original parameters from PurchaseItem.Definition as "new"?

User avatar
Chain_Reaction
Site Admin
Reactions:
Posts: 7604
Joined: December 30th, 2011, 6:00 pm
Answers: 81
Contact:

Post by Chain_Reaction » January 9th, 2016, 12:29 am

Goodness that was almost 2 years ago so I can't recall exactly. I think VS was giving me grief if I left them so I just brute forced it but the memory is foggy. Sorry. Feel free to see what changing it does if needed. :)

icarus_allsorts
Reactions:
Posts: 213
Joined: March 8th, 2012, 6:00 pm

Post by icarus_allsorts » January 9th, 2016, 2:52 pm

Ooo, yet another reminder of how time flies...

Xamarin gave me no trouble for compiling those changes so I went ahead and done them. I already had a version of the interaction that pushed sims to eat in testing in a personal use script mod for a while now so it was relatively simple to implement the change to Cupcake. Working on it again did made me realize that EA seemed to have forgotten to readd the interactions stripped off items put in the display when the items are bought (which I guess wasn't too noticeable in the first place since the items go into the inventory where the interactions still show up, took me a while to catch on to the fact that they go missing when removed from the inventory let alone why) so that's one more change to the interaction.

I'm done with it for now and it looks stable enough for public testing, but before that I just wanted to find out if there are any uncommitted changes on your end for Cupcake Chain?

User avatar
Chain_Reaction
Site Admin
Reactions:
Posts: 7604
Joined: December 30th, 2011, 6:00 pm
Answers: 81
Contact:

Post by Chain_Reaction » January 9th, 2016, 7:39 pm

Nah I haven't touched it in a while. Go ahead and push your changes :)

icarus_allsorts
Reactions:
Posts: 213
Joined: March 8th, 2012, 6:00 pm

Post by icarus_allsorts » January 10th, 2016, 2:13 am

Okay, have submitted a pull request, though it seems the previous Overwatch changes got committed again when I clicked on the "Update from Chain-Reaction/master" in the GitHub client (assuming at the time that this was equivalent to the using "git merge upstream/master" in Git Shell, probably wrong though) and I couldn't find a way to deselect them from the pull request unfortunately. Only committed the cs files and not my Cupcake.csproj this time, but if the csproj file is necessary I'll commit it as well.

User avatar
Chain_Reaction
Site Admin
Reactions:
Posts: 7604
Joined: December 30th, 2011, 6:00 pm
Answers: 81
Contact:

Post by Chain_Reaction » January 10th, 2016, 3:18 am

That is pretty odd, it's acting like they don't already exist on your end. Github does some weird things sometimes but when I merged it then it figured it out. OW changes were discarded. Yes, it's the same thing. They recently added it to the client. Looks good though but just a FYI your OW project file is out dated :)

icarus_allsorts
Reactions:
Posts: 213
Joined: March 8th, 2012, 6:00 pm

Post by icarus_allsorts » January 10th, 2016, 3:30 am

Odd indeed. The correct files are all in my own Projects folder anyways, I might try clearing outmy Github folder and copy the ones from Github to avoid future discrepencies

Post Reply