Oh, one more thing Sir... (since I always forget to say something, I might as well do it in style)
Do you happen to have the supernatural powers to delete a post? Cos I would like to direct nemagani to get the V13 instead of the file linked in that thread, or I could just repost after that one telling them to get V13 instead
Creating an NRaas project OnceRead and OnceReadTablet
- Chain_Reaction
- Site Admin
- Reactions:
- Posts: 7595
- Joined: December 30th, 2011, 6:00 pm
- Contact:
- Chain_Reaction
- Site Admin
- Reactions:
- Posts: 7595
- Joined: December 30th, 2011, 6:00 pm
- Contact:
Yeah, nevermind then, just the 12b file will need to be deleted, I uploaded it here in the first place cos I thought I was going to put that one in Testing but then after dinner I had a revelation, my brain started hammering me about the Predicate in the method and I kept looking at it for 30 minutes before I realized what my brain was trying to tell me
code
- (JunJayMdM) Updated "Choose Book" on the tablet for backpack posture and jetpack posture (Tablet)
- (JunJayMdM) Fixed Twallan change => "Choose Book" on the tablet now lists all books in town (Tablet)
- Changes made to handle ITUN changes made by <a class="wiki_link" href="/Retuner">Retuner</a>
The last one is a change made by Twallan. In V12 Twallan changed to list all books in town and in V13 I fixed that. Also, the postures change made the module compatible for patch 1.63 and above only.
- (JunJayMdM) Updated "Choose Book" on the tablet for backpack posture and jetpack posture (Tablet)
- (JunJayMdM) Fixed Twallan change => "Choose Book" on the tablet now lists all books in town (Tablet)
- Changes made to handle ITUN changes made by <a class="wiki_link" href="/Retuner">Retuner</a>
The last one is a change made by Twallan. In V12 Twallan changed to list all books in town and in V13 I fixed that. Also, the postures change made the module compatible for patch 1.63 and above only.
- Chain_Reaction
- Site Admin
- Reactions:
- Posts: 7595
- Joined: December 30th, 2011, 6:00 pm
- Contact:
The commit of this changed turned out to be pretty interesting due to the pull request having my merge in it. I had to school myself on "cherry picking" commits which ended badly because one file was changed in 2 commits. I pretty much blew the master up. But I fixed it! Please make sure this file contains the correct source now: https://github.com/Chain-Reaction/NRaas ... abletEx.cs
Looks right to me
BTW Why would they make it so every push I make goes directly to an already open Pull Request? The first change to TabletEx I made was not supposed to get there, it was just for me. This forces me not to push anything until the Pull Request is closed. Not a big deal, cos I know now and I can work with it, but I can't help but think they have to rethink a lot of stuff on GitHub, cos as it is now it's full of misleading behavior and lack of actions
BTW Why would they make it so every push I make goes directly to an already open Pull Request? The first change to TabletEx I made was not supposed to get there, it was just for me. This forces me not to push anything until the Pull Request is closed. Not a big deal, cos I know now and I can work with it, but I can't help but think they have to rethink a lot of stuff on GitHub, cos as it is now it's full of misleading behavior and lack of actions
- Chain_Reaction
- Site Admin
- Reactions:
- Posts: 7595
- Joined: December 30th, 2011, 6:00 pm
- Contact:
It's because usually when people submit pull requests they are asked to make changes before the owner agrees to merge. Github thought they were helping people by automatically updating the pull request. You could wait till the request is closed or create a branch of your master and work there. Admittedly that pull request got neglected, I'll check more often.