Hey there,

I think I'm ready to upload test versions for the modules that I updated to work with the additional entry / exit points mod (soon to be posted). Since this is my first time contributing, I have a few questions that will hopefully keep me from making a mess of things.

Firstly, the mods that will be uploaded for testing are as follows:
A) Career - class GoToSchoolInRabbitHoleEx removed (transferred to OW at Chain's suggestion)
B) Overwatch - class GoToSchoolInRabbitHoleEx added (transferred from Career), added slot reassignment code
C) StoryProgressionCareer - added slot reassignment code

All of these should maintain the same functional behaviour that they already have. The new code merely adds support for when someone uses the extra doorways mod.

Questions:
1) Are there any special requirements for uploading as far as approval? I know the package file names remain the same, and the zip files have 2-letter user initials in front. I increased the version numbers for Career and OW to the next number. I left SPCareer as it is since the base mod hasn't increased and simply added an "a" to that one.

2) If there is already another testing version for the same module, should it be left alone or deleted, and am I the one that should do the deleting if that's the case? Overwatch had a recent test update recently.

3) Me and GitHub are not getting along...my puter's op system isn't new enough...lol. I used WinMerge to update the source code and have a new "NRaas-master.zip" file, but I need someone to actually commit it to GitHub for me. Is there a specific place that I need to upload this file to?

I thinks that's it unless there's something else to keep in mind when editing the "Testing Update History" page.

Thanks,

Logan

1) No special requirements but do change the SPCareer version, it's unconventional, I agree, but will cause confusion I'm sure.
2) Just remove the table entry from the update page and remove it from the mod page when you update the revision changes. If you aren't comfortable doing that, you can just leave it. Icarus does and that's fine.
3) Can you zip me up the 3 folders of the mods that changed and upload it here? I'll commit it for you to github.

Tip: When editing the testing update page, next to save there's an arrow, click it and click Switch to Wikitext. I find it much easier to copy and paste table lines and edit the data this way rather than doing each cell one at a time. But that's just me. Note the blank line of bars are the spaces between the release days in the table.

Thanks Chain, you're easy to work with.

I've uploaded the 3 revised mod folders in a .zip for you. Filename is: NRaas_Overwatch_Career_SPCareer_SourceUpdated2015Dec11.zip in case it hides for some reason. I did change that one version to the next number as you requested.

I must say that the Wikitext page is so much easier to work with. I think I've done everything correctly. Looks like much of it is pretty automatic. If you notice anything out of whack, let me know so I don't make the same mistake next time (barring I haven't blown up everyone's pc).

Cheers!

Chain, I reuploaded that NRaas_Overwatch_Career_SPCareer_SourceUpdated2015Dec11.zip file for GitHub. That should overwrite the previous one, correct? If not, let me know, and I'll upload using a different file name.

I blundered the code transfer and accidentally deleted a reference that had to be put back in, so the .csproj file is different in the Careers mod folder. The other two folders should be the same.

Oops....Overwatch mod folder .csproj updated as well (was using actual new code instead of being linked to already existing code...fixed). Sorry

If files are named the same, they do overwrite the older one here, yes.

Couple things:

1) If a version exists in testing already, just add a letter rather than jumping a full version.
2) It appears the sources you compiled OW and Careers against were old as code from the previous versions is missing. Did you compile against the latest sources? I'll fix it up as I was about to release one of them but in the future always grab the latest github source prior to releasing.

Ok, so
1) Overwatch was already in testing, so I should have used version 122a, gotcha. I knew letters were used sometimes. I should have put the numbers I had planned to use in the first post here as well, and you probably would have caught it sooner. Do I need to revise the web page and zip file name, or did you just want to leave it this time?

2) I'm not sure what happened here. So, it was only those two and not SPCareers as well? I had downloaded the NRaas-Master source folder directly from the zip link right before I did all of these, and that's what I used in VS. I actually still have it, but after redownloading it just now, the file sizes are indeed different. Was that missing code something that's going to affect those test versions that I uploaded, or was this just something that affects the source files?

I do apologise...when I realised I had deleted a reference that Careers still needed when transferring that one class to Overwatch, I more than likely messed up when trying to fix it due to being in a panic about messing up someone's game. I will definitely be more careful about this. I know that inaccurate source files would not be a good thing.

1) I've sorted it.
2) SPCareers was perfect. It did affect the test versions as any code missing wouldn't have compiled into the mod. OW was about 3 versions behind but had your changes so like a hybrid if you will. Careers was behind a version. Another note would be if there there's a current test version, import your DLL into that or if not, use the most current release for the sake of translations, those were a bit dated too.

I made an oopsie that I apologize for as well. Shifting the interaction around seems to have really ticked careers off as you noticed. Even moving the helper class back was still causing the custom after school activities to drop on load in my game. I still can't figure out why as I studied that code when I told you to move it and nothing appeared to depend on it. But I've reverted the changes and all is well. I've successfully shifted things around before but this one was a bust and unfortunately added more confusion on your plate than needed.

Overall no harm done, all fixed. I transplanted your slot code into the interaction in careers and fixed the versions and missing code. We all have to start somewhere and overall you did well for your first release.

No worries and thank you so much for cleaning things up. I can obviously see now where I neglected to redownload the Overwatch mod before importing the dll. I had been working on this before Icarus did the test version and forgot to update the copy I was using.

I had redownloaded the master source files though, and I'm still trying to figure out how things derailed with those. SPCareers being correct would imply that I seem to know what I'm doing, but then boneheaded Murphy steps in a vengeance.

Anyways, if I run across something else that might involve new test versions, I will more than likely run things by you first before changing anything on the site, just to be sure I am on track.