Creating an NRaas project Woohooer Hot Air Balloon mistake?

Talk nerdy to us here.
icarus_allsorts
Reactions:
Posts: 213
Joined: March 8th, 2012, 6:00 pm

Woohooer Hot Air Balloon mistake?

Post by icarus_allsorts » March 11th, 2014, 6:33 am

I'm not sure if it's of any consequence, but while looking through the code for Woohooer Hot Air Balloon I noticed this in HotAirBalloonLocationControl.cs :

public override bool HasLocation(Lot lot)
{
return (lot.CountObjects<ShowerOutdoor>() > 0);
}

Not entirely sure but could this be a mistake?

User avatar
JunJayMdM
Reactions:
Posts: 262
Joined: April 2nd, 2012, 6:00 pm

Post by JunJayMdM » March 11th, 2014, 7:38 am

Maybe if there are no outdoor showers in that lot, it doesn't work? Perhaps twallan is using something from that shower?

From what I see that method is used by the KamaSimtra, so it's either a mistake or some trick to make it work properly

User avatar
Chain_Reaction
Site Admin
Reactions:
Posts: 7604
Joined: December 30th, 2011, 6:00 pm
Answers: 81
Contact:

Post by Chain_Reaction » March 12th, 2014, 5:44 am

It does look wrong but he could have had a reason for it. I suppose one way to tell would be to woohoo in the balloon and see if it counts.

icarus_allsorts
Reactions:
Posts: 213
Joined: March 8th, 2012, 6:00 pm

Post by icarus_allsorts » March 12th, 2014, 5:58 am

I don't own the Hot Air Balloon so I've never used this module. I was just surprised to see that mainly because it reminded me of when I made the Eiffel Tower module and I basically copied the LocationControl from the Outdoor Shower module and changed all the instances of ShowerOutdoor to EiffelTower :P (it was later I think that I chose to copy from the WoohooInRabbitHoleEx LocationControl instead)

My first thought was that twallan might have done the exact same thing when he made the module and forgotten to change the one instance, but of course for all I know it was actually deliberate.

User avatar
JunJayMdM
Reactions:
Posts: 262
Joined: April 2nd, 2012, 6:00 pm

Post by JunJayMdM » March 12th, 2014, 6:10 am

Now that you said that I'm more prone to think it's a mistake, cos that sort of thing happens all the time. Like Chain suggested, try woohooing on a balloon and see if the KamaSimtra skill gets points.

icarus_allsorts
Reactions:
Posts: 213
Joined: March 8th, 2012, 6:00 pm

Post by icarus_allsorts » March 12th, 2014, 6:28 am

Should I maybe request someone in the Chatterbox to test since I don't plan on forking over the simpoints for the Hot Air Balloon any time soon?

User avatar
JunJayMdM
Reactions:
Posts: 262
Joined: April 2nd, 2012, 6:00 pm

Post by JunJayMdM » March 12th, 2014, 6:38 am

You know who's going to take that request, right? XD

I don't have it either, if SimAd and Chain don't have it then yeah, I guess you could try asking al...I mean someone :P

icarus_allsorts
Reactions:
Posts: 213
Joined: March 8th, 2012, 6:00 pm

Post by icarus_allsorts » March 12th, 2014, 4:09 pm

Hmm... False alarm after all? http://nraas.wikispaces.com/share/view/ ... d=70452298

Also rather confused by the AddNotches method in Karma Simtra that implements HasLocation, because from what I'm trying to understand from it, when 2 sims Woohoo, the method goes through a randomized list of ALL valid Woohoo locations, finds the first location that the lot currently has (as per the specifications of each location's HasLocation method) and adds notches regarding that location, but I don't see how it is guaranteed that the location chosen matches the location the sims actually woohooed in :S

User avatar
JunJayMdM
Reactions:
Posts: 262
Joined: April 2nd, 2012, 6:00 pm

Post by JunJayMdM » March 12th, 2014, 4:24 pm

Well, after Woohoo an event is sent with the location, which means there's some callback probably doing what you're wondering about. Check the CommonWoohoo class in WoohooerSpace.Interactions. I don't know much about this mod, I just guessed there had to be some callback that indicated the location, so I went looking for it and found that class.

Post Reply