I'm not sure if it's of any consequence, but while looking through the code for Woohooer Hot Air Balloon I noticed this in HotAirBalloonLocationControl.cs :
public override bool HasLocation(Lot lot)
{
return (lot.CountObjects<ShowerOutdoor>() > 0);
}
Not entirely sure but could this be a mistake?
Creating an NRaas project Woohooer Hot Air Balloon mistake?
- icarus_allsorts
- Reactions:
- Posts: 213
- Joined: March 8th, 2012, 6:00 pm
- Chain_Reaction
- Site Admin
- Reactions:
- Posts: 7604
- Joined: December 30th, 2011, 6:00 pm
- Contact:
- icarus_allsorts
- Reactions:
- Posts: 213
- Joined: March 8th, 2012, 6:00 pm
I don't own the Hot Air Balloon so I've never used this module. I was just surprised to see that mainly because it reminded me of when I made the Eiffel Tower module and I basically copied the LocationControl from the Outdoor Shower module and changed all the instances of ShowerOutdoor to EiffelTower (it was later I think that I chose to copy from the WoohooInRabbitHoleEx LocationControl instead)
My first thought was that twallan might have done the exact same thing when he made the module and forgotten to change the one instance, but of course for all I know it was actually deliberate.
My first thought was that twallan might have done the exact same thing when he made the module and forgotten to change the one instance, but of course for all I know it was actually deliberate.
- icarus_allsorts
- Reactions:
- Posts: 213
- Joined: March 8th, 2012, 6:00 pm
- icarus_allsorts
- Reactions:
- Posts: 213
- Joined: March 8th, 2012, 6:00 pm
Hmm... False alarm after all? http://nraas.wikispaces.com/share/view/ ... d=70452298
Also rather confused by the AddNotches method in Karma Simtra that implements HasLocation, because from what I'm trying to understand from it, when 2 sims Woohoo, the method goes through a randomized list of ALL valid Woohoo locations, finds the first location that the lot currently has (as per the specifications of each location's HasLocation method) and adds notches regarding that location, but I don't see how it is guaranteed that the location chosen matches the location the sims actually woohooed in :S
Also rather confused by the AddNotches method in Karma Simtra that implements HasLocation, because from what I'm trying to understand from it, when 2 sims Woohoo, the method goes through a randomized list of ALL valid Woohoo locations, finds the first location that the lot currently has (as per the specifications of each location's HasLocation method) and adds notches regarding that location, but I don't see how it is guaranteed that the location chosen matches the location the sims actually woohooed in :S
Well, after Woohoo an event is sent with the location, which means there's some callback probably doing what you're wondering about. Check the CommonWoohoo class in WoohooerSpace.Interactions. I don't know much about this mod, I just guessed there had to be some callback that indicated the location, so I went looking for it and found that class.